Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php-74 to static tests #1184

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Add php-74 to static tests #1184

merged 1 commit into from
Oct 20, 2020

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 3, 2020

Description (*)

composer.json allows PHP7.0-7.4, so we should also cover 7.4 with static tests.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@sreichel sreichel added the PHP 7.x Related to PHP 7.x label Sep 3, 2020
@sreichel sreichel requested a review from Flyingmana September 3, 2020 15:46
@Flyingmana Flyingmana merged commit 9d38347 into 1.9.4.x Oct 20, 2020
@Flyingmana
Copy link
Contributor

do we really need the checks for all versions of php7?
Maybe only the oldest and newest? Because, each of them takes 5min, and I dont think its likely to have a failure in between them

@sreichel sreichel deleted the sreichel-patch-1 branch October 21, 2020 01:53
@sreichel sreichel added this to the Release 19.4.8 / 20.0.4 milestone Oct 21, 2020
@sreichel sreichel mentioned this pull request Oct 21, 2020
3 tasks
@kkrieger85
Copy link
Contributor

If we'd remove checks, than I'd ensure the latest supported versions are running. See https://www.php.net/supported-versions.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
environment PHP 7.x Related to PHP 7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants