-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Phoenix_Moneybookers #1044
Removed Phoenix_Moneybookers #1044
Conversation
I think Iam missing the reason why this module should be removed. Besides, the linked Repository has an outdated version, the marketplace already had newer versions. |
It can always be added back as a separate extension if anyone is actually using it but I wouldn't assume that because it exists it is being used, necessarily.. I think a more important consideration is do we want to support it? If it isn't compatible with SAQ A I think we should remove it. OpenMage is "use at your own risk" anyway, but it is still good to strongly discourage use of payment methods that are not SAQ A by not including them in core, IMHO. |
Imho it is just shipped with core, but a community extension that has not been updated for years. Is this still maintained - after M1 EOL? There is no public repo to track or report issues, so we have to support it on our own. Do we want this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for removing
I see, as it belongs to a service which is not existing anymore, removing is ok. |
There is a aprrove-button .... ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ther is a aprrove-button .... ;)
Haha, yes.. I hadn't actually looked at the diff yet, though..
I know a little to this conversation, but wouldn't we also want to delete: skin/frontend/base/default/images/moneybookers and skin/adminhtml/default/default/images/moneybookers when getting rid of this extension? |
Yep. There is already a PR ... #1161 |
Ref #988
Should we keep it? If required ... https://github.com/simkea/Phoenix_Moneybookers ...
TODO: setup script to delete config entries (seperate PR)