Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed php5 settings from .htaccess #1001

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Removed php5 settings from .htaccess #1001

merged 1 commit into from
Jun 26, 2020

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented May 23, 2020 •
edited
Loading

Ref #149

@sreichel sreichel added the PHP7 label May 23, 2020
kkrieger85
kkrieger85 approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@kkrieger85 kkrieger85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sreichel sreichel requested a review from Flyingmana June 11, 2020 00:57
@colinmollenhour colinmollenhour merged commit aa14d40 into OpenMage:1.9.4.x Jun 26, 2020
@sreichel sreichel deleted the cleanup/htaccess-php7 branch June 26, 2020 11:43
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
@sreichel @edannenberg
[srcq-OpenMage#1001] Remove PHP 5 settings from .htaccess
d2c6fa9
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 24, 2020
@sreichel @edannenberg
[srcq-OpenMage#1001] Remove PHP 5 settings from .htaccess
38008c3
@colinmollenhour colinmollenhour mentioned this pull request May 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@kkrieger85 kkrieger85 kkrieger85 approved these changes

Assignees
No one assigned
Labels
Cleanup htaccess
Projects
None yet
Milestone
Release 19.4.4 / 20.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @colinmollenhour @kkrieger85