Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: fix rpath handling #5425

Merged
merged 1 commit into from
Dec 26, 2019
Merged

meson: fix rpath handling #5425

merged 1 commit into from
Dec 26, 2019

Conversation

pyhalov
Copy link
Contributor

@pyhalov pyhalov commented Dec 19, 2019

No description provided.

@pyhalov pyhalov requested a review from alarcher December 19, 2019 15:28
@pyhalov
Copy link
Contributor Author

pyhalov commented Dec 19, 2019

The issue is that meson deliberately spoils runpaths at build time and fixes them at install time. pkgsrc patches removed second part of this logic. This leads to strange runpaths...

Have to see how it works with gcc runtimes, when links are necessary (e.g.. some c++ projects).

@pyhalov pyhalov mentioned this pull request Dec 19, 2019
@pyhalov
Copy link
Contributor Author

pyhalov commented Dec 25, 2019

This is incorrect, with this patch I have invalid c++ programs (without RUNPATH).

@pyhalov
Copy link
Contributor Author

pyhalov commented Dec 25, 2019

The issue is that meson adds obviously wrong runpaths to binaries... Likely, we should preserve these patches and fix this 'auto-runpath' mess.
mesonbuild/meson#3882

@pyhalov
Copy link
Contributor Author

pyhalov commented Dec 26, 2019

At least this version doesn't mess gcc runtime runpaths.

@pyhalov pyhalov merged commit 0e5a083 into OpenIndiana:oi/hipster Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant