-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add API documentation #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am delighted to see further API development and pleased to see this timely proposal.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more thoughts and perhaps we could get some syntax highlighting fix.
Co-authored-by: danyill <danyill@users.noreply.github.com>
@danyill I also just added your "plugin bundle archive format" suggestion to the "Missing" section at the bottom. Like all features which I'd rather implement in a distribution or within a plugin, I added it for completeness of our discussion only, and would suggest removing it from |
I just removed the "Missing" section from the bottom. If you think any of the points it listed need to be handled by OpenSCD core in particular, please discuss here: MissingPlugin manifest, searchable plugin storeThis is still needed if we want to enable plugins to be installed and updated from within OpenSCD. This could be done by a "plugin management" or "plugin store" plugin. Otherwise, this could be done by the OpenSCD distribution itself. A good candidate for a plugin manifest format is the Plugin type defined above, with the addition of a Plugin bundle archive formatFor offline installation of plugins (e.g. by dragging and dropping a Plugin update notificationsGiven a plugin manifest with a Within the current architecture, the plugin's own service worker is expected to handle this. Deep linking to editor pluginsCurrently, the only way to open an editor plugin is by clicking on its tab in the tab bar. It would be nice to be able to deep link to a particular editor plugin, for example by clicking on a link in another plugin. This could be handled by the OpenSCD distribution, which could e.g. listen for |
I think a lot of the concept are thought through, but I can imagine if you are not familiar with the history some things could harder to understand. For example I don't know why there are no more validator plugins :) Do you think this is the document to add these reasoning or some other place? |
I think an extra "History" section in the |
You could also document the individual decisions as ADR and link them here ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for all the discussion, 🎯
Onward to implementation 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is our initial draft of an API documentation.
The document is aspirational in nature, meaning it does not reflect the current state of the API, but rather where we would like to be. Code implementing this API is already available in separate branches, so once we have accepted a version of this API doc we can immediately bring the implementation up to speed.