Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] "all" counter updated (#7879) #10105

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

ValentinBouzinFiligran
Copy link
Member

@ValentinBouzinFiligran ValentinBouzinFiligran commented Feb 27, 2025

Proposed changes

  • related relationship count and without related relationship on "all" counter

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@ValentinBouzinFiligran ValentinBouzinFiligran changed the title [frontend] Add support for dynamic configurable required fields to Ca… [frontend] "all" counter updated (#7879) Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.71%. Comparing base (41be254) to head (b6a2f1e).
Report is 5 commits behind head on release/6.6.0.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.6.0   #10105      +/-   ##
=================================================
+ Coverage          64.29%   64.71%   +0.41%     
=================================================
  Files                657      657              
  Lines              63548    63823     +275     
  Branches            7085     7354     +269     
=================================================
+ Hits               40861    41302     +441     
+ Misses             22687    22521     -166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romain-filigran romain-filigran added the filigran team use to identify PR from the Filigran team label Feb 28, 2025
@nino-filigran
Copy link

Validated with @ValentinBouzinFiligran from a functional point of view. There's a deeper issue on counters related to inference rules, that will be tackled in a sperate bug: #10112

@ValentinBouzinFiligran ValentinBouzinFiligran marked this pull request as ready for review February 28, 2025 11:13
@ValentinBouzinFiligran ValentinBouzinFiligran merged commit 9884cb6 into release/6.6.0 Feb 28, 2025
5 checks passed
@ValentinBouzinFiligran ValentinBouzinFiligran deleted the issue/7879-counters branch February 28, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants