Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge stable to develop #2651

Merged
merged 9 commits into from
Feb 24, 2025
Merged

Merge stable to develop #2651

merged 9 commits into from
Feb 24, 2025

Conversation

ReimarBauer
Copy link
Member

@ReimarBauer ReimarBauer commented Feb 22, 2025

Purpose of PR?:
WIP

merge stable to develop

numpy needs to become updated

ReimarBauer and others added 3 commits February 18, 2025 14:03
* CI and development environment overhaul

This removes the docker image logic from the CI setup and instead
replaces it with a setup based on pixi. As part of that it moves the
dependency specification from localbuild/meta.yaml to pixi.toml and
pixi.lock. This turns the MSS repository into a single source of truth
for both the application code as well as the development environment
(whereas the latter was previously only specified in the docker images,
and not reproducible in any way).

Setting up a development environment is as simple as installing pixi and
running `pixi shell` (or `pixi run <cmd>`, or `pixi install` to just
create the environment, etc.). This environment will, by construction,
be the same that is used in the CI as well (modulo platform
differences).

There is a new workflow that periodically (once a week on Monday)
recreates the pixi lockfile and opens a PR for that update. The checks
in that PR essentially serve as a replacement for the previous scheduled
runs to ensure that no dependency update breaks MSS. Merging that PR is
a manual step that can be done just as with any other PR and would then
update the environment on the given target branch. This is essentially
what was previously the triggering of a docker image creation.

Including new dependencies can be done with `pixi add`, which will also
automatically add the dependency to the (pre-existing) lockfile. This
means dependency additions can be part of the PR that necessitate them
and they won't affect the entire environment (as they previously did,
where they would trigger a full image rebuild) but instead just add that
new package to the existing specification.

* fixup! CI and development environment overhaul

* Update commands in development docs

* fixup! CI and development environment overhaul

---------

Co-authored-by: ReimarBauer <rb.proj@gmail.com>
@ReimarBauer ReimarBauer requested a review from matrss February 22, 2025 15:28
@ReimarBauer ReimarBauer marked this pull request as draft February 22, 2025 15:28
@ReimarBauer ReimarBauer marked this pull request as ready for review February 22, 2025 16:51
@ReimarBauer
Copy link
Member Author

I am on the MBP a bit further I have the shell, but the next operation did not succeed

(MSS:dev) (base) reimarbauer@MBP-von-Reimar MSS %  pixi upgrade numpy
Error:
  × Unable to solve pypi dependencies for the tutorials environment because
  │ no compatible python interpreter can be installed for the current
  │ platform
  help: Try converting your [pypi-dependencies] to conda [dependencies]

and verified

- pypi: .
  name: open-mss
  version: 9.3.1
  sha256: 1637f6eb8f19c8a0c14a246c545bb6cab7446313ad2ef9b75ae8eb4d25f59ff7
  editable: true
- conda: https://conda.anaconda.org/conda-forge/linux-64/opencv-4.7.0-py311h38b

@ReimarBauer
Copy link
Member Author

on the linux system I recognized that the versions pinned in tutorials have problems with numpy 2 and I can´t upgrade. I released all pinnings in that section. With creation of the tutorials they might become adjusted.

On the MBP the shell works too.

@ReimarBauer ReimarBauer requested a review from joernu76 February 22, 2025 20:58
Co-authored-by: Matthias Riße <9308656+matrss@users.noreply.github.com>
@ReimarBauer ReimarBauer merged commit ecd2efb into develop Feb 24, 2025
6 of 8 checks passed
@ReimarBauer ReimarBauer deleted the merge_stable_to_develop branch February 24, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants