-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gsoc2024 aryan gupta #2501
Merged
Merged
Gsoc2024 aryan gupta #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhancing the functionality of the MSColab server to allow users to upload small images which would replace generic initials as identifiers during login. This feature personalizes user accounts and significantly enhances the visual aspect of user identification and interaction within the MSColab platform.
…workaryangupta/MSS into feat/visualize-concurrent-users
* updated delete user test to test with and without image * test for unauthorized profile image upload * add assert to check if deleted users profile image is removed
…workaryangupta/MSS into feat/visualize-concurrent-users
…t-users feat: Real-Time tracking of active users in an operation
…024-AryanGupta Merge develop branch to GSOC2024-AryanGupta branch
* separate channel for service messages * enhance collaborator list by integrating user avatars and active status indicator * detailed service messages : moved waypoint, inserted waypoint, deleted waypoint
Merge develop into GSOC2024-AryanGupta
matrss
approved these changes
Sep 3, 2024
@@ -213,14 +275,15 @@ def handle_file_save(self, json_req): | |||
op_id = json_req['op_id'] | |||
content = json_req['content'] | |||
comment = json_req.get('comment', "") | |||
messageText = json_req.get('messageText') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have really been called message_text
. Unfortunately, it seems like flake8 doesn't check for naming conventions...
@@ -576,6 +576,9 @@ def __init__(self, parent=None, data_dir=None): | |||
# Gravatar image path | |||
self.gravatar = None | |||
|
|||
# Service message text for flight-track changes (waypoints inserted, moved or deleted) | |||
self.lastChangeMessage = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming conventions again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
This is a GSOC branch merge of the recent work by Aryan Gupta