improve for testings log_file_level = DEBUG #2277

Preetam-Das26 · 2024-03-12T17:15:35Z

Purpose of PR?:

Fixes #2221

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes

Checklist:

Bug fix. Fixes #
New feature (Non-API breaking changes that adds functionality)
PR Title follows the convention of <type>: <subject>
Commit has unit tests

Preetam-Das26 · 2024-03-12T17:46:51Z

@ReimarBauer Please tell if the changes are correct.

ReimarBauer · 2024-03-12T19:13:03Z

@joernu76 Do you want debug loggings for the wms?

ReimarBauer · 2024-03-12T19:15:18Z

For my problem this change did not help, because https://github.com/Open-MSS/MSS/blob/develop/pytest.ini#L6
forces log_file_level = DEBUG not only in our library.

Preetam-Das26 · 2024-03-12T19:42:28Z

Does this work?

joernu76 · 2024-03-13T08:03:15Z

This looks fine!
However, the/a major problem is that the matplotlib library floods us with messages.

This is a humongous issue also with production servers.

Could you leave our stuff on DEBUG, but set the matplotlib logger to info? That would be very, veeery helpful.

Preetam-Das26 · 2024-03-13T17:20:17Z

Ok sure

Preetam-Das26 · 2024-03-18T18:23:53Z

Kindly check if the changes are correct. @ReimarBauer @joernu76

ReimarBauer · 2024-03-20T19:52:16Z

pytest.ini

@@ -3,7 +3,7 @@ log_cli = 1
 log_cli_level = ERROR
 log_cli_format = %(message)s
 log_file = pytest.log
-log_file_level = DEBUG
+log_file_level = INFO


this should be kept DEBUG because pytest is only used for development.

When there are tests failing or the code has problems you usually want to show in pytest.log
and add debug messages.

Preetam-Das26 · 2024-03-23T08:33:39Z

Kindly check the changes @ReimarBauer

ReimarBauer · 2024-03-26T17:56:24Z

mslib/mswms/wms.py

@@ -146,7 +146,7 @@ def verify_pw(username, password):
 from mslib.utils.coordinate import get_projection_params

 # Logging the Standard Output, which will be added to the Apache Log Files
-logging.basicConfig(level=logging.DEBUG,


keep in the whole MSS code the existing DEBUG.

On the server site a user has to use their own plot class, data classes to extend the existing. Usually that did not work on first attempt. They need these debug messages.

ReimarBauer · 2024-03-26T17:57:47Z

mslib/msui/mpl_map.py

@@ -55,6 +55,8 @@
 OPENAIP_NOTICE = "Airspace data used comes from openAIP.\n" \
                 "Visit openAIP.net and contribute to better aviation data, free for everyone to use and share."
 OURAIRPORTS_NOTICE = "Airports provided by OurAirports."
+mpl_logger = logging.getLogger('matplotlib')


changing the mpl_logger is the needed solution.

but we need our own debug messages in all mslib modules

ReimarBauer

changing the mpl_logger is the needed solution.

but we need our own debug messages in all mslib modules

ReimarBauer · 2024-04-17T14:47:15Z

Will that be continued?

Preetam-Das26 · 2024-04-17T17:39:40Z

Probably it cannot be done now.

Preetam-Das26 · 2024-05-14T08:57:10Z

Will this work @ReimarBauer ?

ReimarBauer

this is a solution for python 2 which enables a user to redefine the states, maybe we can create later a follow up on this idea if it can be practicable used in py3

https://github.com/moinwiki/moin-1.9/tree/master/wiki/config/logging

https://docs.python.org/3/library/logging.config.html#logging.config.fileConfig

the duplication of the lines may be improved

ReimarBauer · 2024-05-15T05:28:04Z

mslib/msidp/idp_conf.py

@@ -183,17 +183,17 @@ def sso_dir_path(local_file):
            "stderr": {
                "class": "logging.StreamHandler",
                "stream": "ext://sys.stderr",
-                "level": "DEBUG",
+                "level": "INFO",


this was DEBUG

ReimarBauer · 2024-05-15T05:30:58Z

conftest.py

@@ -38,6 +40,11 @@
 from mslib.mswms.demodata import DataFiles
 import tests.constants as constants

+matplotlib_logger = logging.getLogger('matplotlib')
+matplotlib_logger.setLevel(logging.INFO)
+mslib_logger = logging.getLogger('mslib')


this now changes any of our logging entries to debug. I think we should only change the 'matplotlib' logging

limit the code repetition by importing that, see above

ReimarBauer · 2024-05-15T05:36:45Z

mslib/msui/mpl_qtwidget.py

@@ -94,6 +94,11 @@
    "plot_title_size": "default",
    "axes_label_size": "default"}

+mpl_logger = logging.getLogger('matplotlib')


i would expect such blocks always after the import definition

and if it is always the same lines, can that become imported from an mslib.utils.loggerdef or other place?

ReimarBauer · 2024-05-21T07:47:20Z

mslib/utils/loggerdef.py

@@ -0,0 +1,8 @@
+# logging_config.py


please add the MSS header, see template

ReimarBauer · 2024-05-21T11:24:40Z

mslib/utils/loggerdef.py

+
+    This file is part of MSS.
+
+    :copyright: Copyright 2017 Main Contributor


What is your name @Preetam-Das26
and the year should be 2024, something like

:copyright: Copyright 2024 Preetam-Das26

ReimarBauer · 2024-05-21T11:25:02Z

mslib/utils/loggerdef.py

+    This file is part of MSS.
+
+    :copyright: Copyright 2017 Main Contributor
+    :copyright: Copyright 2016-2023 by the MSS team, see AUTHORS.


fix the year too

ReimarBauer

Thx

Preetam-Das26 and others added 2 commits March 12, 2024 22:40

CHANGE FROM DEBUG TO INFO

9cdffdf

Merge branch 'Open-MSS:develop' into log

155517b

ReimarBauer requested a review from joernu76 March 12, 2024 19:12

Preetam-Das26 added 2 commits March 13, 2024 01:00

changed to INFO level in pytest.ini file

54624db

Merge branch 'log' of https://github.com/Preetam-Das26/MSS into log

d8da9c2

Preetam-Das26 and others added 4 commits March 15, 2024 01:49

Merge branch 'Open-MSS:develop' into log

311ea83

matplotlib logger info 23:29

34cab93

Merge branch 'Open-MSS:develop' into log

f7295d9

Merge branch 'log' of https://github.com/Preetam-Das26/MSS into log

2a695a8

ReimarBauer reviewed Mar 20, 2024

View reviewed changes

Preetam-Das26 added 2 commits March 21, 2024 20:29

matlplotlib 20:29

105239f

Merge branch 'develop' of https://github.com/Preetam-Das26/MSS into log

eacc651

ReimarBauer reviewed Mar 26, 2024

View reviewed changes

ReimarBauer requested changes Mar 26, 2024

View reviewed changes

02:35

1ef7e3d

ReimarBauer reviewed May 14, 2024

View reviewed changes

ReimarBauer reviewed May 15, 2024

View reviewed changes

Preetam-Das26 added 2 commits May 16, 2024 02:32

02:28

73fe824

02:43

4fd5cc3

Preetam-Das26 requested a review from ReimarBauer May 16, 2024 15:20

ReimarBauer reviewed May 21, 2024

View reviewed changes

mslib/utils/loggerdef.py Outdated

@@ -0,0 +1,8 @@

# logging_config.py

Copy link

Member

ReimarBauer May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the MSS header, see template

Preetam-Das26 added 2 commits May 21, 2024 14:43

14:43

48e0a20

14:53

8b59fec

ReimarBauer reviewed May 21, 2024

View reviewed changes

Preetam-Das26 and others added 2 commits May 22, 2024 03:20

03:20

f734287

fix year worked on the module

caf7517

ReimarBauer approved these changes May 22, 2024

View reviewed changes

ReimarBauer merged commit cabee4e into Open-MSS:develop May 22, 2024
10 checks passed

Preetam-Das26 deleted the log branch May 22, 2024 08:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve for testings log_file_level = DEBUG #2277

improve for testings log_file_level = DEBUG #2277

Preetam-Das26 commented Mar 12, 2024

Preetam-Das26 commented Mar 12, 2024

ReimarBauer commented Mar 12, 2024

ReimarBauer commented Mar 12, 2024

Preetam-Das26 commented Mar 12, 2024

joernu76 commented Mar 13, 2024

Preetam-Das26 commented Mar 13, 2024

Preetam-Das26 commented Mar 18, 2024

ReimarBauer Mar 20, 2024

Preetam-Das26 commented Mar 23, 2024

ReimarBauer Mar 26, 2024

ReimarBauer Mar 26, 2024

ReimarBauer left a comment

ReimarBauer commented Apr 17, 2024

Preetam-Das26 commented Apr 17, 2024

Preetam-Das26 commented May 14, 2024

ReimarBauer left a comment •

edited

Loading

ReimarBauer May 15, 2024

ReimarBauer May 15, 2024

ReimarBauer May 15, 2024

ReimarBauer May 15, 2024

ReimarBauer May 21, 2024

ReimarBauer May 21, 2024 •

edited

Loading

ReimarBauer May 21, 2024

ReimarBauer left a comment


		This file is part of MSS.

		:copyright: Copyright 2017 Main Contributor

improve for testings log_file_level = DEBUG #2277

improve for testings log_file_level = DEBUG #2277

Conversation

Preetam-Das26 commented Mar 12, 2024

Preetam-Das26 commented Mar 12, 2024

ReimarBauer commented Mar 12, 2024

ReimarBauer commented Mar 12, 2024

Preetam-Das26 commented Mar 12, 2024

joernu76 commented Mar 13, 2024

Preetam-Das26 commented Mar 13, 2024

Preetam-Das26 commented Mar 18, 2024

Choose a reason for hiding this comment

Preetam-Das26 commented Mar 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ReimarBauer left a comment

Choose a reason for hiding this comment

ReimarBauer commented Apr 17, 2024

Preetam-Das26 commented Apr 17, 2024

Preetam-Das26 commented May 14, 2024

ReimarBauer left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ReimarBauer May 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ReimarBauer left a comment

Choose a reason for hiding this comment

ReimarBauer left a comment •

edited

Loading

ReimarBauer May 21, 2024 •

edited

Loading