Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made MSColab timeout configurable. #1916

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Made MSColab timeout configurable. #1916

merged 3 commits into from
Aug 24, 2023

Conversation

joernu76
Copy link
Member

Fix #1915

@joernu76 joernu76 requested a review from ReimarBauer August 21, 2023 05:33
ReimarBauer
ReimarBauer requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment, the value is two elements, so list_options fits better

@ReimarBauer ReimarBauer self-requested a review August 21, 2023 20:46
@ReimarBauer
Copy link
Member

I agree with this but want to understand what is the difference to the other option first.

@ReimarBauer ReimarBauer merged commit add03a5 into develop Aug 24, 2023
@ReimarBauer ReimarBauer deleted the i1915 branch August 24, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReimarBauer ReimarBauer ReimarBauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TimeOut errors on bad internet connection/strange firewall
2 participants
@joernu76 @ReimarBauer