Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hello2 not called, better solution. #1892

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Conversation

ReimarBauer
Copy link
Member

just don't use a decorator here.

@ReimarBauer ReimarBauer requested a review from joernu76 August 11, 2023 14:58
@ReimarBauer
Copy link
Member Author

normally indented decorators should give an indention error. However this didn't and also flake8 had no problem.

In our case we just need to have auth.login_required() called when we submit data.

@ReimarBauer ReimarBauer linked an issue Aug 11, 2023 that may be closed by this pull request
@ReimarBauer
Copy link
Member Author

discussed with Andi and Klaus, the indentation was not the problem. I did'nt call hello2.
But as we only have to call auth.login_required() the new solution is much nicer

@ReimarBauer ReimarBauer changed the title indented decorators are not working hello2 not called, better solution. Aug 11, 2023
@ReimarBauer ReimarBauer merged commit bde5a5e into stable Aug 13, 2023
@ReimarBauer ReimarBauer deleted the fix_decorator_failure branch August 13, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix wrong usage of decorator
2 participants