Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper disabling of unticked KML files. #1869

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Proper disabling of unticked KML files. #1869

merged 1 commit into from
Aug 10, 2023

Conversation

joernu76
Copy link
Member

@joernu76 joernu76 commented Aug 9, 2023

Fix #1866

@joernu76 joernu76 requested review from ReimarBauer and jgrooss August 9, 2023 11:40
@joernu76 joernu76 linked an issue Aug 9, 2023 that may be closed by this pull request
tick/untick for multiple kml overlays does not work #1866
Closed
@jgrooss
Copy link
Contributor

jgrooss commented Aug 9, 2023

This seems to work. At least I don't see the problem anymore

jgrooss
jgrooss previously approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@jgrooss jgrooss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have solved the problem

ReimarBauer
ReimarBauer requested changes Aug 9, 2023
View reviewed changes
Copy link
Member

@ReimarBauer ReimarBauer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is another problem, not checked if it is a new one.

When you click on change color on a not check marked kml it crashes.
Same with resize.

change_color_problem

@joernu76
Copy link
Member Author

joernu76 commented Aug 9, 2023

will have a look

ReimarBauer
ReimarBauer approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@joernu76 joernu76 merged commit 82723a7 into stable Aug 10, 2023
@joernu76 joernu76 deleted the i1866b branch August 24, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReimarBauer ReimarBauer ReimarBauer approved these changes

@jgrooss jgrooss jgrooss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tick/untick for multiple kml overlays does not work
3 participants
@joernu76 @jgrooss @ReimarBauer