Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken remove/clear_figure link. #1858

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Fix broken remove/clear_figure link. #1858

merged 4 commits into from
Aug 10, 2023

Conversation

joernu76
Copy link
Member

@joernu76 joernu76 commented Aug 6, 2023

Fix #1857

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linearview needs a different implemention for clear_figure, see

remove_not_working

@joernu76
Copy link
Member Author

joernu76 commented Aug 9, 2023

This was a separate issue, but is now fixed as well.

@ReimarBauer
Copy link
Member

ReimarBauer commented Aug 9, 2023

There is a difference on clearing

On sideview the vertical line markers are kept. We keep also on topview the flightpath. So I think if that is not a tremdemous effort we should keep the vertical lines and coordinates, indicating the flightpath in linearview too.

difference_to_sv

@joernu76
Copy link
Member Author

This is not easily possible as the lines are not stored as separate patches in contrast to the image in SideView. This requires refactoring beyond a stable fix. Please transfer this request to a new issue, which I will take care of in develop.

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@ReimarBauer ReimarBauer merged commit c22c083 into stable Aug 10, 2023
@ReimarBauer ReimarBauer deleted the i1857 branch August 10, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linearview and Sideview crash on Clear figure by clicking on the remove button
2 participants