Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Shortcuts should only be shortcut listings and no option for search #1734

Merged
merged 10 commits into from
Apr 5, 2023
Merged

Enhancement: Shortcuts should only be shortcut listings and no option for search #1734

merged 10 commits into from
Apr 5, 2023

Conversation

sratslla
Copy link
Contributor

@sratslla sratslla commented Apr 4, 2023

fixes #1733

@sratslla sratslla changed the title I1733 Enhancement: Shortcuts should only be shortcut listings and no option for search Apr 4, 2023
ReimarBauer
ReimarBauer requested changes Apr 5, 2023
View reviewed changes
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected. I have just seen that we are not changing the window title.

I think we should fix this in the same PR, because now both windows are having a better functionality.

title_search

The search window should have the title "Search -- MSUI"

@ReimarBauer
Copy link
Member

the build gallery problem I have introduced, by my cleanup on dockerhub today.

@sratslla
Copy link
Contributor Author

sratslla commented Apr 5, 2023

Understood!

ReimarBauer
ReimarBauer approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@ReimarBauer ReimarBauer merged commit b3617ae into Open-MSS:develop Apr 5, 2023
@sratslla sratslla deleted the i1733 branch April 12, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReimarBauer ReimarBauer ReimarBauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shortcut window acts like Search window if opened after Closing Search Window
2 participants
@sratslla @ReimarBauer