GLOBAL variables changed to GLOBAL constants

[rootxrishabh]

fixes #1629

[ReimarBauer]

see comment

[ReimarBauer]

Do you see some airdata in the widget?

[rootxrishabh]

Do you see some airdata in the widget?

Is this correct?

[ReimarBauer]

For some reason I don't get any airport shown.

They do download and have a big size

ls -rtlh downloads/aip/airports.csv 
-rw-rw-r-- 1 reimar reimar 11M Mar 23 12:34 downloads/aip/airports.csv

But I always get
ERROR: Tried to draw airports but none were found. Try redownloading.

Have a look on this line, this misses the new "download" folder.
https://github.com/rootxrishabh/MSS/blob/i1629/mslib/utils/airdata.py#L126

I assume you have in .config/msui an older airports.csv file and that's why you can see data. But the newer version from the download folder is not used

[ReimarBauer]

is missing

diff --git a/mslib/utils/airdata.py b/mslib/utils/airdata.py
index 751d090f..f173f5a9 100644
--- a/mslib/utils/airdata.py
+++ b/mslib/utils/airdata.py
@@ -123,9 +123,9 @@ def get_airports(force_download=False, url=None):
             == QtWidgets.QMessageBox.Yes:
         download_progress(os.path.join(OSDIR, "downloads", "aip", "airports.csv"), url)
 
-    if os.path.exists(os.path.join(OSDIR, "airports.csv")):
-        with open(os.path.join(OSDIR, "airports.csv"), "r", encoding="utf8") as file:
-            _airports_mtime = os.path.getmtime(os.path.join(OSDIR, "airports.csv"))
+    if os.path.exists(os.path.join(OSDIR, "downloads", "aip", "airports.csv")):
+        with open(os.path.join(OSDIR, "downloads", "aip", "airports.csv"), "r", encoding="utf8") as file:
+            _airports_mtime = os.path.getmtime(os.path.join(OSDIR, "downloads", "aip", "airports.csv"))
             return list(csv.DictReader(file, delimiter=","))
 
     else:

[rootxrishabh]

is missing

diff --git a/mslib/utils/airdata.py b/mslib/utils/airdata.py
index 751d090f..f173f5a9 100644
--- a/mslib/utils/airdata.py
+++ b/mslib/utils/airdata.py
@@ -123,9 +123,9 @@ def get_airports(force_download=False, url=None):
             == QtWidgets.QMessageBox.Yes:
         download_progress(os.path.join(OSDIR, "downloads", "aip", "airports.csv"), url)
 
-    if os.path.exists(os.path.join(OSDIR, "airports.csv")):
-        with open(os.path.join(OSDIR, "airports.csv"), "r", encoding="utf8") as file:
-            _airports_mtime = os.path.getmtime(os.path.join(OSDIR, "airports.csv"))
+    if os.path.exists(os.path.join(OSDIR, "downloads", "aip", "airports.csv")):
+        with open(os.path.join(OSDIR, "downloads", "aip", "airports.csv"), "r", encoding="utf8") as file:
+            _airports_mtime = os.path.getmtime(os.path.join(OSDIR, "downloads", "aip", "airports.csv"))
             return list(csv.DictReader(file, delimiter=","))
 
     else:

I have synced the current PR branch and I am still not able to reproduce the error, can you please check? Also which 2 branches are you comparing?

[ReimarBauer]

is missing

diff --git a/mslib/utils/airdata.py b/mslib/utils/airdata.py
index 751d090f..f173f5a9 100644
--- a/mslib/utils/airdata.py
+++ b/mslib/utils/airdata.py
@@ -123,9 +123,9 @@ def get_airports(force_download=False, url=None):
             == QtWidgets.QMessageBox.Yes:
         download_progress(os.path.join(OSDIR, "downloads", "aip", "airports.csv"), url)
 
-    if os.path.exists(os.path.join(OSDIR, "airports.csv")):
-        with open(os.path.join(OSDIR, "airports.csv"), "r", encoding="utf8") as file:
-            _airports_mtime = os.path.getmtime(os.path.join(OSDIR, "airports.csv"))
+    if os.path.exists(os.path.join(OSDIR, "downloads", "aip", "airports.csv")):
+        with open(os.path.join(OSDIR, "downloads", "aip", "airports.csv"), "r", encoding="utf8") as file:
+            _airports_mtime = os.path.getmtime(os.path.join(OSDIR, "downloads", "aip", "airports.csv"))
             return list(csv.DictReader(file, delimiter=","))
 
     else:

I have synced the current PR branch and I am still not able to reproduce the error, can you please check? Also which 2 branches are you comparing?

show me ls -l .config/msui

and look at the image, which shows your repository file

line 125 has the correct path, but those below were not changed.

[ReimarBauer]

We not only want to download to os.path.join(OSDIR, "downloads", "aip", "airports.csv") we want also to read from there.

[rootxrishabh]

Moin @ReimarBauer, I have made some changes can you please review them?

[ReimarBauer]

Thx