Fix bug in view (q)settings handling #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joernu76
force-pushed
the
fix_setttings
branch
2 times, most recently
from
209cc12 to
55ff493
Compare
ReimarBauer
requested changes
Mar 20, 2023
mslib/msui/mpl_qtwidget.py
Outdated
| "secondary_axis": "no secondary axis", | ||
| "plot_title_size": "default", | ||
| "axes_label_size": "default", | ||
| "flightlevels": [], |
There was a problem hiding this comment.
an old entry was:
https://github.com/Open-MSS/MSS/pull/1705/files#diff-46d3dceb21b8fa62a87ac72721c0c16241048c1eef22ecc21fa3786f282f8f6bL68
"flightlevels": [300, 320, 340]
I'm not verified if that was used, just seen in the review
ReimarBauer
reviewed
Mar 20, 2023
ReimarBauer
requested changes
Mar 20, 2023
* consistent naming of dialogs * consistent naming of settings * move of load/store to one base class * move of default settings to global, private variables for simpler (testing) access
|
found a different problem. The stored draw flight track color is not used for the initialization on a restart in the Sideview After clicking options and ok, they are updated in Topview this is doing as expected |
ReimarBauer
requested changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.