few todos solved (#2650)

---------

Co-authored-by: Matthias Riße <9308656+matrss@users.noreply.github.com>

mslib/msui/mscolab.py

@@ -872,7 +872,7 @@ def on_context_menu(point):
         self.profile_dialog.usernameLabel_2.setText(self.user['username'])
         self.profile_dialog.mscolabURLLabel_2.setText(self.mscolab_server_url)
         self.profile_dialog.emailLabel_2.setText(self.email)
-        self.profile_dialog.deleteAccountBtn.clicked.connect(self.delete_account)
+        self.profile_dialog.deleteAccountBtn.clicked.connect(self.delete_own_account)
         self.profile_dialog.uploadImageBtn.clicked.connect(self.upload_image)
 
         # add context menu for right click on image
@@ -928,8 +928,7 @@ def upload_image(self, _=None):
                                      f'Cannot identify image file. Please check the file format. Error: {e}')
 
     @verify_user_token
-    def delete_account(self, _=None):
-        # ToDo rename to delete_own_account
+    def delete_own_account(self, _=None):
         reply = QMessageBox.question(
             self.ui, self.tr('Continue?'),
             self.tr("You're about to delete your account. You cannot undo this operation!"),

tests/_test_mscolab/test_sockets_manager.py

@@ -165,19 +165,14 @@ def test_get_messages(self):
         sio = self._connect()
         sio.emit('start', {'token': self.token})
 
-        # ToDo same message gets twice emitted, why? (use a helper function)
-        sio.emit("chat-message", {
-            "op_id": self.operation.id,
-            "token": self.token,
-            "message_text": "message from 1",
-            "reply_id": -1
-        })
-        sio.emit("chat-message", {
-            "op_id": self.operation.id,
-            "token": self.token,
-            "message_text": "message from 1",
-            "reply_id": -1
-        })
+        for _ in range(2):
+            sio.emit("chat-message", {
+                "op_id": self.operation.id,
+                "token": self.token,
+                "message_text": "message from 1",
+                "reply_id": -1
+            })
+
         with self.app.app_context():
             messages = self.cm.get_messages(1)
             assert messages[0]["text"] == "message from 1"
@@ -195,19 +190,13 @@ def test_get_messages(self):
     def test_get_messages_api(self):
         sio = self._connect()
         sio.emit('start', {'token': self.token})
-        # ToDo same message gets twice emitted, why?
-        sio.emit("chat-message", {
-            "op_id": self.operation.id,
-            "token": self.token,
-            "message_text": "message from 1",
-            "reply_id": -1
-        })
-        sio.emit("chat-message", {
-            "op_id": self.operation.id,
-            "token": self.token,
-            "message_text": "message from 1",
-            "reply_id": -1
-        })
+        for _ in range(2):
+            sio.emit("chat-message", {
+                "op_id": self.operation.id,
+                "token": self.token,
+                "message_text": "message from 1",
+                "reply_id": -1
+            })
 
         token = self.token
         data = {