Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v21.6.4] Check superblock CRC before it is used #652

Merged
merged 3 commits into from
Jan 25, 2022

Conversation

arutk
Copy link
Contributor

@arutk arutk commented Jan 25, 2022

No description provided.

Robert Baldyga and others added 3 commits January 19, 2022 15:42
Superblock can be used during load of other sections, so we need to check
its CRC before other sections are loaded.

Signed-off-by: Robert Baldyga <robert.baldyga@intel.com>
Signed-off-by: Adam Rutkowski <adam.j.rutkowski@intel.com>
This function must be fixed to work with metadata flapping. Until then
mark as not supported

Signed-off-by: Adam Rutkowski <adam.j.rutkowski@intel.com>
@arutk arutk force-pushed the v21.6.4-fix-flapping branch from 65c3cde to d78842d Compare January 25, 2022 16:03
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #652 (f5a41ef) into v21.6.4 (24d1d8b) will increase coverage by 0.99%.
The diff coverage is 61.53%.

❗ Current head f5a41ef differs from pull request most recent head d78842d. Consider uploading reports for the commit d78842d to get more accurate results

@@             Coverage Diff             @@
##           v21.6.4     #652      +/-   ##
===========================================
+ Coverage    68.55%   69.55%   +0.99%     
===========================================
  Files           83       83              
  Lines         9195     9088     -107     
===========================================
+ Hits          6304     6321      +17     
+ Misses        2891     2767     -124     
Impacted Files Coverage Δ
src/engine/cache_engine.h 100.00% <ø> (ø)
src/metadata/metadata.h 100.00% <ø> (ø)
src/mngt/ocf_mngt_cache.c 78.50% <50.00%> (ø)
src/metadata/metadata_superblock.c 77.18% <50.94%> (-7.34%) ⬇️
src/metadata/metadata.c 74.35% <85.00%> (+13.57%) ⬆️
src/engine/cache_engine.c 61.45% <100.00%> (+1.24%) ⬆️

@robertbaldyga robertbaldyga merged commit c2dd225 into Open-CAS:v21.6.4 Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants