Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WISH: change debase and enbase to always use base value (remove /base refinement) #2411

Closed
Oldes opened this issue Mar 27, 2020 · 0 comments
Closed

Comments

@Oldes
Copy link
Owner

Oldes commented Mar 27, 2020

When I checked my sources, I quite a lot use /base refinement with debase and enbase functions.
As the word base is already part of these functions names, I believe, the code would be more clear if base value was always required and specified as a first argument.

So instead of debase/base something 2 one would use debase 2 something.

It breaks compatibility with old code, but I think it would be a nice change. Especially when there is new possible base value 85 -> #2410

@Oldes Oldes changed the title WISH: change debase and enbase to always use base value as a first argument WISH: change debase and enbase to always use base value (remove /base refinement) Mar 28, 2020
Oldes added a commit to Oldes/Rebol3 that referenced this issue Mar 29, 2020
…unctions

So eliminating ugly `??base/base` code, for example instead of:
```
debase/base data 16
```
it is now just:
```
debase data 16
```

I'm still not sure if the `base` value should not be as a first argument, but so far I will just keep it as a second one.

Implements: Oldes/Rebol-issues#2411
@Oldes Oldes added Oldes.resolved Bugs/wishes with Oldes' fixes/features Test.written labels Jun 20, 2020
@Oldes Oldes closed this as completed Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant