Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test node consensus #1384

Merged
merged 32 commits into from
Dec 21, 2022
Merged

Test node consensus #1384

merged 32 commits into from
Dec 21, 2022

Conversation

tsahee
Copy link
Collaborator

@tsahee tsahee commented Dec 13, 2022

merging #1334 + some fixes

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Dec 13, 2022
@tsahee tsahee requested a review from rauljordan December 13, 2022 04:29
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #1384 (cca148a) into master (ab34773) will decrease coverage by 3.32%.
The diff coverage is n/a.

❗ Current head cca148a differs from pull request most recent head aa20009. Consider uploading reports for the commit aa20009 to get more accurate results

@@            Coverage Diff             @@
##           master    #1384      +/-   ##
==========================================
- Coverage   52.11%   48.78%   -3.33%     
==========================================
  Files         257      245      -12     
  Lines       33822    29733    -4089     
  Branches      555      555              
==========================================
- Hits        17625    14505    -3120     
+ Misses      14141    13163     -978     
- Partials     2056     2065       +9     

@tsahee tsahee force-pushed the test-node-consensus branch from daf2bee to 9ba3e61 Compare December 13, 2022 15:18
rauljordan
rauljordan previously approved these changes Dec 13, 2022
Copy link
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tsahee for helping me include this and fix conflicts! LGTM. Soon we'll be able to amend this to start from proof-of-state at genesis, which will be very helpful

@rauljordan
Copy link
Contributor

See prysmaticlabs/prysm#11746

@kasey
Copy link

kasey commented Dec 13, 2022

See prysmaticlabs/prysm#11746

Are you ok starting from bellatrix? To start e2e from other forks you'll need to wait a few days for prysmaticlabs/prysm#11750

Copy link
Contributor

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally :)

@PlasmaPower PlasmaPower merged commit 8b28bdc into master Dec 21, 2022
@hkalodner hkalodner deleted the test-node-consensus branch December 23, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants