Remove googletest source code remains #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are no longer needed, as there were only used by autoconf builds. For CMake, we either use external googletest, or use CMake download capabilities.
|
Looks like a good clean-up. I was considering changing some of the googletest framework (e.g. use FetchContent instead of ExternalProject), but ultimately these will wait until the next CMake version bump, which I'll probably look into for 2023. |
mwtoews
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are no longer needed, as there were only used by autoconf builds.
For CMake, we either use external googletest, or use CMake download capabilities.