Update Arangodb packaged version to using 3.12.4

[JoshuaSBrown]

PR Description

Update Arangodb version and pull officially supported version, update documentation.

Tasks

• - A description of the PR has been provided, and a diagram included if it is a new feature.
• - Formatter has been run
• - CHANGELOG comment has been added
• - Labels have been assigned to the pr
• - A reviwer has been added
• - A user has been assigned to work on the pr

Summary by Sourcery

Update Arangodb to version 3.12.4.

Build:

• Update Arangodb installation script to use the new version and updated Debian repository.

Deployment:

• Update Arangodb Docker image to version 3.12.4.

Documentation:

• Update documentation to reflect the Arangodb version change.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request updates the ArangoDB version to 3.12.4. It modifies the installation script to use the new version and updates the docker compose files to use the new image.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Updated the ArangoDB installation script to use version 3.12.4.	Updated the download URL for the ArangoDB release key to use the 3.12.4 version. Updated the repository URL to use the 3.12.4 version.	scripts/dependency_install_functions.sh
Updated the docker compose files to use the ArangoDB 3.12.4 image.	Changed the arango image to arangodb/arangodb:3.12.4 in compose/all/compose.yml. Changed the arango image to arangodb/arangodb:3.12.4 in compose/metadata/compose.yml.	compose/all/compose.yml compose/metadata/compose.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @JoshuaSBrown - I've reviewed your changes - here's some feedback:

Overall Comments:

• The PR description mentions documentation updates, but there don't appear to be any changes to the documentation files in the diff.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: Add error handling for the Release key download

Consider adding error checking after the curl command to ensure the Release key was downloaded successfully before proceeding with the installation.

Suggested change

	curl -OL https://download.arangodb.com/arangodb312/DEBIAN/Release.key
	"$SUDO_CMD" apt-key add - < Release.key
	if ! curl -OL https://download.arangodb.com/arangodb312/DEBIAN/Release.key; then
	echo "Failed to download ArangoDB Release key"
	return 1
	fi
	if [ ! -s Release.key ]; then
	echo "ArangoDB Release key file is empty or missing"
	return 1
	fi
	"$SUDO_CMD" apt-key add - < Release.key

[JoshuaSBrown]

I will not add this without testing, but it looks like a good suggestion.

[JoshuaSBrown]

Can this be added as a new issue to possibly refactor this part of the script.

[sourcery-ai]

I have created an issue for your comment: #1275