Skip to content

Improve test_ragone_chart. #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2016
Merged

Improve test_ragone_chart. #148

merged 2 commits into from
May 5, 2016

Conversation

Rombur
Copy link
Collaborator

@Rombur Rombur commented May 4, 2016

Since load charge is not implemented yet. This test cannot reach 100% of coverage.

@dalg24
Copy link
Collaborator

dalg24 commented May 4, 2016

Actually what you want to use here is probably BOOST_DATA_TEST_CASE. I use it in test_equivalent_circuit.cc or you can directly look at the doc

@codecov-io
Copy link

codecov-io commented May 4, 2016

Current coverage is 92.30%

Merging #148 into master will increase coverage by +0.66%

  1. File ...test_ragone_chart.cc was modified. more
    • Misses -27
    • Partials 0
    • Hits +27
@@             master       #148   diff @@
==========================================
  Files            67         67          
  Lines          4283       4309    +26   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           3924       3977    +53   
+ Misses          359        332    -27   
  Partials          0          0          

Powered by Codecov. Last updated by 1db33dc...19f5b18

@Rombur
Copy link
Collaborator Author

Rombur commented May 4, 2016

I use BOOST_DATA_TEST_CASE

@Rombur
Copy link
Collaborator Author

Rombur commented May 4, 2016

OK this test is not 100% because of the constant load and the throws. Do you want me to remove the throws?

@dalg24
Copy link
Collaborator

dalg24 commented May 4, 2016

what's the reason for not having the constant load here?

@dalg24
Copy link
Collaborator

dalg24 commented May 4, 2016

because we only have equivalent circuits and they do have the method implemented don't they?

@dalg24
Copy link
Collaborator

dalg24 commented May 5, 2016

No you're right...

@dalg24
Copy link
Collaborator

dalg24 commented May 5, 2016

We could use expected failure otherwise

@dalg24
Copy link
Collaborator

dalg24 commented May 5, 2016

Also, would you remove SeriesRC:: and ParallelRC::reset(...)?

@dalg24
Copy link
Collaborator

dalg24 commented May 5, 2016

You can use the decorator boost::unit_test::expected_failures(N)

@Rombur
Copy link
Collaborator Author

Rombur commented May 5, 2016

No, you are right. The code throws because in the test there are several places where we don't support constant_load. I didn't pay attention why the code was throwing.

@Rombur
Copy link
Collaborator Author

Rombur commented May 5, 2016

I have removed the useless throws and the load_charge.

@dalg24 dalg24 merged commit d27b68b into ORNL-CEES:master May 5, 2016
@dalg24 dalg24 mentioned this pull request May 5, 2016
16 tasks
@Rombur Rombur deleted the test branch May 11, 2016 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants