Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teensy 4.0 Example #26

Closed
wants to merge 2 commits into from
Closed

Conversation

gannaramu
Copy link

@gannaramu gannaramu commented Oct 28, 2020

Description

Added an Example using Teensy4.0 and Wiz850io Ethernet Shield.

Fixes # (issue)
#25

Type of change

Please uncheck options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • I have made the appropriate changes to documentation already
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes, including relevant hardware setups. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B
    I have tested it using a teensy4.0 connected to Wiz850io ethernet shield over SPI.

Test Configuration:

  • Device type: Teensy 4.0
  • SSLClient version: 1.6.9 (installed from Arduino IDE)
  • Arduino core version: 1.8.13
  • Additional library versions: uses Ethernet Library from teensyduino installer.
  • Hardware: Teensy 4.0, Wiz850io

@prototypicalpro
Copy link
Member

This looks good! I've been super busy recently, but as soon as I have a free moment I'll add this board to the CI pipeline and then I can merge the PR. Thanks for the contribution!

@gannaramu
Copy link
Author

Looks like you have used arduino-cli for your CI pipeline but teensy is not yet supported by arduino-cli. I made a workaround if you want to look at it. https://github.com/gannaramu/Teensy-Github-Action

@prototypicalpro
Copy link
Member

Thanks for pointing that out! Unfortunately the CI for this project needs to support so many different platforms that I ended up making a pipeline with the arduino-cli and PlatformIO, with PlatformIO to compiling the teensy--it's overly complicated, but it is able to test pretty much any target. With this pipeline, I was able to get your example to compile on the other platforms with only a few minor modifications (switching to EthernetLarge and removing Serial.printf), so I moved it to be available with the other examples as EthernetAWSIoT. I went ahead and packaged all these changes in #28 so I wasn't pushing a ton of modifications to your branch, and it should be published in v1.6.10. Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants