plat-hikey: define DRAM1_BASE for defining the size of TA's secure memory when building OP-TEE #6123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etienne-lms
reviewed
Jun 17, 2023
TaihuLight
changed the title
|
@etienne-lms Thank you for your review. I fixed the commit, the define could work for both Hikey 960 and HiKey. |
etienne-lms
reviewed
Jun 28, 2023
There was a problem hiding this comment.
The change looks good to me but the commit message should be updated to something like:
plat-hikey: make DRAM1_BASE configurable
Adds CFG_DRAM1_BASE configuration switch in the platform to allow
one to tune DRAM1_SIZE.
Signed-off-by: ...
Please use your full name in your Signed-off-by tag.
|
@etienne-lms I have fixed the commit message. |
|
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plat-hikey: make DRAM1_BASE configurable
Adds CFG_DRAM1_BASE configuration switch in the platform to allow one to tune DRAM1_SIZE.
#5146
#4768
#6160
Signed-off-by: Loonloon cloudiot@126.com