Consistently use font variables and added stylistic set 1 for Open Sans #2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbarnes9
added
Enhancement
jrbarnes9
changed the title
boxadesign
approved these changes
Oct 24, 2022
jrbarnes9
added
Tech improvements
boxadesign
pushed a commit
that referenced
this pull request
Feb 17, 2023
…ns (#2507) * added open sans with ss01 * replaced font weight values with variables and updated bold var to 700 * added bold open sans with ss1 * import typography vars to pattern lib styles [test-visual]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Resolves #1933 and fixes #2144
How to review
Check fonts consistent correctly render regular (400) and bold (700) with opentail lowercase 'g' and serfied capital 'I'.