Fix: Make input prefix/suffix params mandatory to render component #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d params [test-visual]
jrbarnes9
changed the title
jrbarnes9
requested review from
rmccar,
kruncher and
boxadesign
and removed request for
rmccar and
kruncher
rmccar
reviewed
Jul 21, 2022
Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
kruncher
approved these changes
Jul 25, 2022
rmccar
approved these changes
Jul 26, 2022
boxadesign
pushed a commit
that referenced
this pull request
Feb 17, 2023
…2349) * added conditions to require prefix/suffix params * updated macro options for durations suffix to document objects params * updated all prefix/suffix examples to make sure they have all required params [test-visual] * updated mutually exclusive tests to add mandatory prefix/suffix id * added condition to require prefix/suffix title to render * added input tests to check for prefix/suffix id [test-visual] * Update src/components/input/_macro.njk Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com> Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes #2344
idset because it's required foraria-labelledbyon the inputtitleset because it's required for<abbr>element to be validWhat are the breaking changes?
params.prefixmust set bothparams.prefix.idandparams.prefix.titleto render.params.suffixmust set bothparams.suffix.idandparams.suffix.titleto render.How to review