Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fieldset - Remove bottom margin if wrapping a h1 #1783

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

boxadesign
Copy link
Contributor

What is the context of this PR?

Remove bottom margin if fieldset is wrapping a h1 (using parameter legendIsQuestionTitle).

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #1783 (b35220f) into master (ddb05cc) will increase coverage by 0.09%.
The diff coverage is 96.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1783      +/-   ##
==========================================
+ Coverage   96.39%   96.49%   +0.09%     
==========================================
  Files          65       69       +4     
  Lines        2746     3107     +361     
==========================================
+ Hits         2647     2998     +351     
- Misses         99      109      +10     
Impacted Files Coverage Δ
src/components/timeout-modal/timeout.js 92.96% <92.96%> (ø)
src/tests/spec/modal/modal.spec.js 98.41% <98.41%> (ø)
src/tests/spec/timeout-modal/timeout-modal.spec.js 99.18% <99.18%> (ø)
src/components/modal/modal.js 100.00% <100.00%> (ø)
src/components/tabs/tabs.js 91.24% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a76bba5...b35220f. Read the comment docs.

@boxadesign boxadesign merged commit 33ffeb1 into master Dec 7, 2021
@boxadesign boxadesign deleted the remove-margin-from-legendIsQuestionTitle branch December 7, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants