Remove use of classes in table variants #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbarnes9
added
the
Breaking changes
boxadesign
previously approved these changes
Nov 4, 2021
rmccar
previously approved these changes
Nov 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #1744 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 62 62
Lines 2640 2640
=======================================
Hits 2545 2545
Misses 95 95
Continue to review full report at Codecov.
|
boxadesign
approved these changes
Nov 5, 2021
rmccar
approved these changes
Nov 5, 2021
boxadesign
pushed a commit
that referenced
this pull request
Feb 17, 2023
* improved sass and changed row highlight colour * added new param to macros table * updated docs * replaced classes and bools with singel variants array * updated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
What is the context of this PR?
variantsparameter which can take an array to set the different variations of tables.Also...
row-hoverhas been changed to use the same variable for highlighting other elements:$color-highlightdensevariant has been changed tocompactWhat is the breaking change?
onsTable()macro will need to replace the use oftable_class,class,sortableandscrollableparameters with a new single parametervariantswhich can be set with an array of values or a single string e.g."variants": ['scrollable', 'row-hover']<table>,<th>, and<td>, but the params have changed to:tableClasses,thClassesandtdClasses, for consistency with other components.How to review
Check all table variants work as expected and check docs