-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkboxes/radios - Add select all and allow under 'other' reveal #1732
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1732 +/- ##
==========================================
+ Coverage 94.11% 96.39% +2.27%
==========================================
Files 66 65 -1
Lines 2668 2746 +78
==========================================
+ Hits 2511 2647 +136
+ Misses 157 99 -58
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply these same content changes also to the radio component (where applicable)
New params need adding to macro options tables |
Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Selecting the nested radio labels in "Checkbox with revealed radios" doesn't check the input
src/components/checkboxes/examples/checkboxes-other-checkboxes/index.njk
Outdated
Show resolved
Hide resolved
src/components/checkboxes/examples/checkboxes-other-radios/index.njk
Outdated
Show resolved
Hide resolved
src/components/checkboxes/examples/checkboxes-autoselect/index.njk
Outdated
Show resolved
Hide resolved
…ex.njk Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
….njk Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
…ign-system into add-more-to-other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
) * WIP initial work * JS work for select all * Tweak selector * Add radios and examples * Fix existing tests * Tidy up examples * Add tests for autoselect * Fix test * Added tests for checkbox other with child fieldset * Update src/components/checkboxes/index.njk Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com> * Update src/components/checkboxes/index.njk Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com> * Update src/components/checkboxes/index.njk Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com> * Update src/components/checkboxes/index.njk Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com> * Update src/components/checkboxes/index.njk Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com> * Update src/components/checkboxes/index.njk Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com> * Update src/components/checkboxes/index.njk Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com> * Update src/components/checkboxes/index.njk Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com> * Update src/components/checkboxes/index.njk Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com> * Updates from review * Updated macro options * Fix label issue * Update src/components/checkboxes/examples/checkboxes-other-radios/index.njk Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com> * Update src/tests/spec/checkboxes/checkboxes-with-autoselect.spec.js Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com> * Update src/components/checkboxes/examples/checkboxes-autoselect/index.njk Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com> * Updated to allow child checkboxes to be checked by default * Added visually hidden to revealed elements legend * Fixed legend issue Co-authored-by: Jon Barnes <43346934+jrbarnes9@users.noreply.github.com>
What is the context of this PR?
To do - Add unit tests for new scripts
How to review
Check examples, documentation