Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Add improved error message for buffer allocation failure in HE-MEM (#3096) #3102

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

a-thompson2
Copy link
Contributor

Description

Cherry-pick of changes in d005f44

Collateral (docs, reports, design examples, case IDs):

  • Document Update Required? (Specify FIM/AFU/Scripts)

Tests added:

Tests run:

…HE-MEM (OFS#3096)

* Add message notifying user of buffer allocation failure

* Fix mistake in catch blocks

* Fix caught exceptions not being references

* Fix typo

* Move SRC try-catch to only include the allocate call

* Throw exception after outputting message to user

* Remove unnecessary copies when rethrowing
@a-thompson2 a-thompson2 requested a review from a team as a code owner February 13, 2024 19:09
Copy link
Contributor

@pcolberg pcolberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @a-thompson2!

@a-thompson2 a-thompson2 merged commit 0f91de3 into OFS:release/2.12.0 Feb 13, 2024
8 checks passed
@a-thompson2 a-thompson2 deleted the release-cherrypick branch February 13, 2024 19:14
@a-thompson2 a-thompson2 restored the release-cherrypick branch February 13, 2024 19:17
@a-thompson2 a-thompson2 deleted the release-cherrypick branch February 13, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants