-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:improve fpgametrics output readability and #3075
Conversation
anandaravuri
commented
Jan 12, 2024
- update fpga metrics index numbered from 1-42 (instead of 0-41)
- improve fpgametrics output readability
- group power and thermal sensor strings and values
- update fpga metrics index numbered from 1-42 (instead of 0-41) - improve fpgametrics output readability - group power and thermal sensor strings and values Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anandaravuri! Is there any benefit to moving from 0-based to 1-based indexing? Is it for consistency with other indexed output?
current fpgametrics output display Sensor details numbering 0 to 39 ( starting from 0)
0 | thermal_mgmt:Board Temperature #2 | Board Temperature #2 | 44.50 Celsius Fix:fpgametrics output display Sensor details index 1 to 40
1 | thermal_mgmt:Board Temperature #2 | Board Temperature #2 | 44.50 Celsius |
Pull Request Test Coverage Report for Build 7559621910
💛 - Coveralls |
- update fpga metrics index numbered from 1-42 (instead of 0-41) - improve fpgametrics output readability - group power and thermal sensor strings and values Signed-off-by: anandaravuri <ananda.ravuri@intel.com>