[Bug] Disallow factory image update if boot page is also factory #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandhv
changed the title
tswhison
reviewed
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The BMC disallows this combo to prevent the user from bricking the card. But it returns a non-descript error message.
I enhanced fpgasupdate to additionally check for this combo and error out.
We need to compare 2 things:
To facilitate #2, I added a boot_page sysfs_node object to the 'fme' device in fpga.py. It looks for the specific name of the entry.
I then read the entry in main() and perform the check.
Signed-off-by: Venkateswaran, Anandh anandh.venkateswaran@intel.com
Collateral (docs, reports, design examples, case IDs):
https://hsdes.intel.com/appstore/article/#/14020513236
https://hsdes.intel.com/appstore/article/#/14020332395
Tests added:
Tests run:
Manually tested on Comet-Creek using all combinations of boot-page and target flash page. When both are 'factory', we error-out gracefully. For all other combos, the operation completed successfully.