Fix: correct issue pointed out by static analysis #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
anandaravuri
approved these changes
Nov 17, 2023
tswhison
pushed a commit
that referenced
this pull request
Nov 17, 2023
### Description Static analysis complained that although a destructor had been defined in class vfio_device, there was not a corresponding copy ctor nor assignment operator. The variable is treated as a Singleton in the application, so no copying occurs. Implementing the constructor and assignment operator as deleted solves the issue. ### Collateral (docs, reports, design examples, case IDs): - [ ] Document Update Required? (Specify FIM/AFU/Scripts) ### Tests added: ### Tests run: CI Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
tswhison
pushed a commit
that referenced
this pull request
Nov 17, 2023
… (#3046) * Fix: correct issue pointed out by static analysis (#3044) ### Description Static analysis complained that although a destructor had been defined in class vfio_device, there was not a corresponding copy ctor nor assignment operator. The variable is treated as a Singleton in the application, so no copying occurs. Implementing the constructor and assignment operator as deleted solves the issue. ### Collateral (docs, reports, design examples, case IDs): - [ ] Document Update Required? (Specify FIM/AFU/Scripts) ### Tests added: ### Tests run: CI Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Static analysis complained that although a destructor had been defined in class vfio_device, there was not a corresponding copy ctor nor assignment operator. The variable is treated as a Singleton in the application, so no copying occurs. Implementing the constructor and assignment operator as deleted solves the issue.
Collateral (docs, reports, design examples, case IDs):
Tests added:
Tests run:
CI