Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] website_odoo_debranding #921

Merged
merged 24 commits into from
Dec 30, 2022

Conversation

yibudak
Copy link

@yibudak yibudak commented Oct 28, 2022

No description provided.

@pedrobaeza
Copy link
Member

/ocabot migration website_odoo_debranding

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 28, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 28, 2022
13 tasks
@luke-stdev001
Copy link

luke-stdev001 commented Oct 30, 2022

@yibudak ,

Thanks for your work on this!

It looks like there is some portal-related branding leftover here:
https://github.com/odoo/odoo/blob/16.0/addons/portal/views/portal_templates.xml#L223-L235

Is this within the scope of this module?

@yibudak
Copy link
Author

yibudak commented Oct 31, 2022

@yibudak ,

Thanks for your work on this!

It looks like there is some portal-related branding leftover here: https://github.com/odoo/odoo/blob/16.0/addons/portal/views/portal_templates.xml#L223-L235

Is this within the scope of this module?

image
Hello,
This template is related to portal module and it's debranded with server-brand/portal_odoo_debranding.
https://github.com/OCA/server-brand/blob/14.0/portal_odoo_debranding/views/portal_templates.xml

Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on Runboat, it works.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot migration website_odoo_debranding
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-921-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c2f3af7 into OCA:16.0 Dec 30, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 44e7d96. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.