[16.0][IMP] stock_quant_manual_assign: Improve assign_quants() performance #2312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AungKoKoLin1997
force-pushed
the
16.0-oca-imp-stock_quant_manual_assign
branch
from
5e5fec8 to
01efa4d
Compare
yostashiro
reviewed
Apr 7, 2025
AungKoKoLin1997
force-pushed
the
16.0-oca-imp-stock_quant_manual_assign
branch
from
01efa4d to
58873d2
Compare
rousseldenis
reviewed
Apr 9, 2025
There was a problem hiding this comment.
@AungKoKoLin1997 Thanks for this. Could you add tests that cover the move lines to unlink case ?
AungKoKoLin1997
force-pushed
the
16.0-oca-imp-stock_quant_manual_assign
branch
from
58873d2 to
737a57a
Compare
yostashiro
reviewed
Apr 9, 2025
stock_quant_manual_assign/tests/test_stock_quant_manual_assign.py
Outdated
Show resolved
Hide resolved
AungKoKoLin1997
force-pushed
the
16.0-oca-imp-stock_quant_manual_assign
branch
from
737a57a to
755307c
Compare
AungKoKoLin1997
force-pushed
the
16.0-oca-imp-stock_quant_manual_assign
branch
from
755307c to
3780f83
Compare
yostashiro
reviewed
Apr 10, 2025
stock_quant_manual_assign/tests/test_stock_quant_manual_assign.py
Outdated
Show resolved
Hide resolved
stock_quant_manual_assign/tests/test_stock_quant_manual_assign.py
Outdated
Show resolved
Hide resolved
AungKoKoLin1997
force-pushed
the
16.0-oca-imp-stock_quant_manual_assign
branch
4 times, most recently
from
b1d2cfc to
cdaa609
Compare
Previously, when there were hundreds of quants assigned to a stock move, it would take a very long time for assign_quants() to complete, as the system would try to reassign all selected quants. This commit mitigates the issue by identifying only the necessary changes — specifically, the move lines to be unlinked and the quant lines to be assigned — so that updates are made only to those records. Co-Authored-By: Yoshi Tashiro <tashiro@quartile.co>
AungKoKoLin1997
force-pushed
the
16.0-oca-imp-stock_quant_manual_assign
branch
from
cdaa609 to
ad5b398
Compare
|
@rousseldenis Could you please review the PR? |
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when there were hundreds of quants assigned to a stock move, it would take a very long time for assign_quants() to complete, as the system would try to reassign all selected quants.
This PR mitigates the issue by identifying only the necessary changes — specifically, the move lines to be unlinked and the quant lines to be assigned — so that updates are made only to those records.
@qrtl QT5295