-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][FIX] base_report_to_printer: Report send to printer when is rendered from email template #373
Conversation
… from email template
""" | ||
return super( | ||
MailTemplate, self.with_context(must_skip_send_to_printer=True) | ||
).generate_email(res_ids, fields) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this solution is already covered in a module that is not migrated.
https://github.com/OCA/report-print-send/blob/14.0/base_report_to_printer_mail/models/mail_template.py
I don't know if it is convenient to keep it separate and migrate the other module.
What?? There is a module to fix other module?? |
Then that module should disappear with a merge script. I leave it as a comment in case someone uses it, not in our case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That module exists because the dependency in this module is web
, not mail
. You may say that both modules are always installed, but that's not really something that you can assure, so I think that changing the dependency mustn't be done here, but on a new version, and for now, to migrate the other module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that is quite absurd to have that glue module, but let's migrate this and move on...
Migration of module #374 |
cc @Tecnativa TT51079
ping @chienandalu @pilarvargas-tecnativa