Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] base_report_to_printer: Report send to printer when is rendered from email template #373

Conversation

sergio-teruel
Copy link

"""
return super(
MailTemplate, self.with_context(must_skip_send_to_printer=True)
).generate_email(res_ids, fields)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this solution is already covered in a module that is not migrated.
https://github.com/OCA/report-print-send/blob/14.0/base_report_to_printer_mail/models/mail_template.py

I don't know if it is convenient to keep it separate and migrate the other module.

@sergio-teruel
Copy link
Author

What?? There is a module to fix other module??
I think that if you install base_report_to_printer in any instance the mail module allways will be installed, this is the reason by adding web dependency and fix it inside the module...

@pilarvargas-tecnativa
Copy link

What?? There is a module to fix other module?? I think that if you install base_report_to_printer in any instance the mail module allways will be installed, this is the reason by adding web dependency and fix it inside the module...

Then that module should disappear with a merge script. I leave it as a comment in case someone uses it, not in our case.

@pedrobaeza pedrobaeza added this to the 15.0 milestone Oct 23, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That module exists because the dependency in this module is web, not mail. You may say that both modules are always installed, but that's not really something that you can assure, so I think that changing the dependency mustn't be done here, but on a new version, and for now, to migrate the other module.

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that is quite absurd to have that glue module, but let's migrate this and move on...

@sergio-teruel
Copy link
Author

Migration of module #374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants