feat(pylint): Add support for pylint version 1.6.4 #67
Conversation
Make changes neded for support verion 1.6.4 of pylint. OCA#58
|
PR on pylint20 failed because of this bug that @moylop260 reported: pylint-dev/astroid#358 Works good on my local machine with a virtualenv and up to date setuptools |
|
Thanks Could you check if you can propose it for astroid/pylint project and version that you are using now? |
| py27-pylint20: git+https://github.com/PyCQA/astroid@461e016 | ||
| py27-pylint20: git+https://github.com/PyCQA/pylint@0495355 | ||
| py27-pylint14: pylint==1.6.4 | ||
| py27-pylint20: git+https://github.com/PyCQA/astroid@master |
There was a problem hiding this comment.
Please freeze the 2.0 version in order to avoid future builds red.
There was a problem hiding this comment.
FYI I'm using a good newest sha without errors in our fork:
https://github.com/Vauxoo/pylint-odoo/blob/master/tox.ini#L25
There was a problem hiding this comment.
Use latest astroid stable version 1.4.7
… on pylin20 test According to comments from @MOYLOP pinn astroid & pylint versions
|
@moylop260 please help; I'm not very familiar with travis and the way it build the test environments. I already tried using the latest commits on astroid & pylint and locally builds but travis failed; tried with the commits you have on your fork travis failed again, and tried updating just astroid for include the patch you done while keeping master on your pinned commit and failed again. All times my local dev & test machines running tox -e py27-pylint20,profile-stats build without problem. What do you think could be the problem and how can I solved it? |
|
My secret weapon to reproduce travis error on local is t2d with the original image of travis
|
|
Hello? |
|
I'm really sorry but for good and for bad we are plenty of work at this time. I'm get back to this as soon as I can or fell free to finish for me if you wish. |
|
Superseeded by #69 |
Make changes needed for support verison 1.6.4 of pylint.
According with our conversation on #58 in this PR I'm proposing the changes needed for support latest pylint version. Also get back pylint20 on tox to point to master as this commit fix that build too.