[MIG][16.0] product_packaging_type_pallet => product_packaging_level_pallet #1216
Conversation
Currently translated at 100.0% (6 of 6 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_packaging_type_pallet Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_packaging_type_pallet/es/
|
/ocabot migration product_packaging_type_pallet |
rousseldenis
force-pushed
the
16.0-mig-product-packaging-level-pallet-dro
branch
from
0902b25 to
14fada9
Compare
|
|
||
| |badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
|
||
| This module adds specific fields to manage product packaging types for pallets. |
There was a problem hiding this comment.
| This module adds specific fields to manage product packaging types for pallets. | |
| This module adds specific fields to manage product packaging levels for pallets. |
There was a problem hiding this comment.
No, don't change this, it is a package type specialization, not a package level
| # Copyright 2019 Camptocamp SA | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl) | ||
| { | ||
| "name": "Product Packaging Type Pallet", |
There was a problem hiding this comment.
| "name": "Product Packaging Type Pallet", | |
| "name": "Product Packaging Level Pallet", |
There was a problem hiding this comment.
No, don't change this, it is a package type specialization, not a package level
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl) | ||
| { | ||
| "name": "Product Packaging Type Pallet", | ||
| "summary": "Manage packaging of pallet type", |
There was a problem hiding this comment.
| "summary": "Manage packaging of pallet type", | |
| "summary": "Manage packaging level of pallet", |
There was a problem hiding this comment.
No, don't change this, it is a package type specialization, not a package level
| @@ -0,0 +1,29 @@ | |||
| # Project C2C Migration information | |||
There was a problem hiding this comment.
This file should be removed
There was a problem hiding this comment.
Now that we have package level and package types, this needs to be migrated to the right logistic concept.
It is a packaging type that can be marked as a pallet.
It doesn't make sense to mark a package level as a pallet. A pallet is a tertiary level. There is always one and only one tertiary level. However, you can have multiple package type on a tertiary level and some can be marked as pallet.
Rename the module, and remove the dependency on product_packaging_level. Set is_pallet on package type instead.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
Hi, thanks for this contribution. On my side, regarding the python code I don't know why this module depends on product_packaging_dimension. None of the python code is related to this module. Probably only because of the xml view. To guess what is a pallet, I suppose that level can be used without this module (convention by project ?) Do you what'll become this PR ? Thanks |
github-actions
bot
removed
the
stale
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
LGTM @rousseldenis @pedrobaeza tested. it seems good. any idea when can we merge this? |
github-actions
bot
removed
the
stale
|
@rousseldenis ping |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
@rousseldenis @jbaudoux Could you attend to this PR and save it from being lost? |
Depends on: