Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] rename_models: don't call get_model2table #403

Merged

Conversation

MiquelRForgeFlow
Copy link
Contributor

The names in ir_model_data use the model converted name instead of table name.

The names in ir_model_data use the model converted name instead of table name.
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the problem

@MiquelRForgeFlow
Copy link
Contributor Author

This is from v16:

Selection_4356

You can see that is shows model_mailing_contact_subscription instead of model_mailing_contact_list_rel. The same in base module, where base.model_ir_actions_actions exists instead of base.model_ir_actions. Same argument for the model data of fields.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now I understand. Good catch!

@pedrobaeza pedrobaeza merged commit 098c42e into OCA:master Feb 28, 2025
2 checks passed
@MiquelRForgeFlow MiquelRForgeFlow deleted the master-fix-rename_models-model_table branch February 28, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants