[IMP] rename_modules: rename rating mixin parent_res_model as well #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndd-odoo
force-pushed
the
imp_rename_modules
branch
from
7e24f19 to
f5538ce
Compare
openupgradelib/openupgrade.py
Outdated
| @@ -1079,6 +1079,12 @@ def rename_models(cr, model_spec): | |||
| "UPDATE mail_activity SET res_model=%s where res_model=%s", | |||
| (new, old), | |||
| ) | |||
| if is_module_installed(cr, "rating"): | |||
There was a problem hiding this comment.
Better check if table existe.
There was a problem hiding this comment.
@legalsylvain ok as you wish sir
There was a problem hiding this comment.
Don't check both. Only the table existence.
There was a problem hiding this comment.
@pedrobaeza Okay, done sir, i saw the above check both so i copy :v
There was a problem hiding this comment.
Yes, it's true that the module installed check is used up on the code for mail. I suppose that one was for not having to check a lot of table existence and as the module name is expected to be constant. In this case, I think one check is enough.
There was a problem hiding this comment.
Okay, that 's fine by me
legalsylvain
approved these changes
Sep 13, 2023
ndd-odoo
force-pushed
the
imp_rename_modules
branch
from
f5538ce to
128ce80
Compare
ndd-odoo
force-pushed
the
imp_rename_modules
branch
from
128ce80 to
f4d5dc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not , rating feature will be gone for good