[FIX] mail_activity_type rename in merge_models method #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestotejeda
force-pushed
the
fix-merge_models-method
branch
2 times, most recently
from
a584415 to
03d884f
Compare
|
ping @pedrobaeza |
|
Please explain here and in the commit message why this, pointing to the model line where it's seen the change on the model data. |
From Odoo version 15.0, in `mail.activity.type` model, the field that stores a reference to `res.model` is `res_model` and not `res_model_id` field as in previous versions, so we need to take this into account in the merge_models method when updating mail.activity.type. Odoo 14.0: https://github.com/odoo/odoo/blob/fe87755a4499f68de4625fd9940f25960896bc55/addons/mail/models/mail_activity.py#L58 odoo 15.0: https://github.com/odoo/odoo/blob/5553ad50bf54bef986038f94e8c8462e2547a927/addons/mail/models/mail_activity_type.py#L46
ernestotejeda
force-pushed
the
fix-merge_models-method
branch
from
03d884f to
006cd46
Compare
|
@pedrobaeza done. I put the explanation in the Pull Request description and in the commit message |
pedrobaeza
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc @Tecnativa TT41247
From Odoo version 15.0, in
mail.activity.typemodel, the field that stores a reference tores.modelisres_modeland notres_model_idfield as in previous versions, so we need to take this into account in themerge_modelsmethod when updatingmail.activity.type.Odoo 14.0: https://github.com/odoo/odoo/blob/fe87755a4499f68de4625fd9940f25960896bc55/addons/mail/models/mail_activity.py#L58
odoo 15.0: https://github.com/odoo/odoo/blob/5553ad50bf54bef986038f94e8c8462e2547a927/addons/mail/models/mail_activity_type.py#L46