Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] rename_models: Avoid mogrify 'IndexError: tuple index out of range' for % LIKE parameter #312

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

rousseldenis
Copy link
Contributor

No description provided.

@pedrobaeza
Copy link
Member

Can you minimize the diff? I suppose you have isort in your pipeline, but here it's not applied. We can include pre-commit stuff though in this library, but it should be in a separate PR.

@rousseldenis
Copy link
Contributor Author

Can you minimize the diff? I suppose you have isort in your pipeline, but here it's not applied. We can include pre-commit stuff though in this library, but it should be in a separate PR.

Yes, it's my IDE config. If in separate commits ok for you ?

@pedrobaeza
Copy link
Member

If we don't put whole pre-commit thing, I wouldn't change anything of that, even in a separate commit here. It should be handled separately.

@rousseldenis
Copy link
Contributor Author

@pedrobaeza Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants