[16.0] [ADD] Add helper to migrate translations from ir_translation table to model table #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marielejeune
force-pushed
the
16.0-migrate_translations-mle
branch
from
736cb40 to
084dc5a
Compare
lmignon
suggested changes
Sep 20, 2022
There was a problem hiding this comment.
Thank you @marielejeune for this contribution. I propose some changes. See comment.
|
As reference, the Odoo change motivating this PR comes from odoo/odoo#97692 |
marielejeune
force-pushed
the
16.0-migrate_translations-mle
branch
3 times, most recently
from
c9985f7 to
bc3331a
Compare
lmignon
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Thank you @marielejeune. LGTM (code review, functional test)
|
This PR has the |
pedrobaeza
reviewed
Sep 24, 2022
marielejeune
force-pushed
the
16.0-migrate_translations-mle
branch
2 times, most recently
from
0147b8f to
6b88e48
Compare
|
@pedrobaeza Can you update your review? Thanks! |
|
Please fix these flake8 erros: |
marielejeune
force-pushed
the
16.0-migrate_translations-mle
branch
from
6b88e48 to
00ccb79
Compare
…able to model table
marielejeune
force-pushed
the
16.0-migrate_translations-mle
branch
from
00ccb79 to
cf92e08
Compare
|
@pedrobaeza sorry, done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.