[IMP] convert_field_to_html: be ablet to avoid spamming query for each row #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uhm, the operation is not the same right now... You can add a |
What do you mean? |
|
You are not processing each content and pass |
|
ah, shit. right! 🤦♂️ |
MiquelRForgeFlow
force-pushed
the
master-imp-convert_field_to_html
branch
from
ea402a8 to
7cdcfa7
Compare
pedrobaeza
reviewed
Sep 12, 2022
MiquelRForgeFlow
force-pushed
the
master-imp-convert_field_to_html
branch
from
7cdcfa7 to
24efb18
Compare
pedrobaeza
approved these changes
Sep 12, 2022
MiquelRForgeFlow
force-pushed
the
master-imp-convert_field_to_html
branch
2 times, most recently
from
cfaff9a to
6eb5ca8
Compare
pedrobaeza
approved these changes
Sep 12, 2022
MiquelRForgeFlow
force-pushed
the
master-imp-convert_field_to_html
branch
from
6eb5ca8 to
f936c98
Compare
MiquelRForgeFlow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v15, this method is used several times and some times in tables that usually have many rows.