[FIX] disable_invalid_filters: <module 'time' (built-in)> can not be used in evaluation contexts

[royle-vietnam]

This error will save archive all filters
=> Prefer providing only the items necessary for your intended use as attributes of odoo.tools.safe_eval

[pedrobaeza]

This has been working perfectly during several versions. Is it a problem in v14? Why? If so, you must restrict it to such version, not on the rest.

[royle-vietnam]

This has been working perfectly during several versions. Is it a problem in v14? Why? If so, you must restrict it to such version, not on the rest.

Yes, it is a problem in v14 (all filters is archived)
How to restrict it to such version?

[pedrobaeza]

But I don't get why. Having an extra argument shouldn't be the reason for that. I have migrated to v14 already some DBs and don't have this problem.

[royle-vietnam]

But I don't get why. Having an extra argument shouldn't be the reason for that. I have migrated to v14 already some DBs and don't have this problem.

Because if error occurs, except clause will be handled, so all filters is archived
Did you check all the filters in the db after the migration? You can check at menu Settings / Technical / User-defined Filters

[royle-vietnam]

But I don't get why. Having an extra argument shouldn't be the reason for that. I have migrated to v14 already some DBs and don't have this problem.

The following code generates that message, however, I see no need to use time in the safe_eval

https://github.com/odoo/odoo/blob/1c82a66cf975203b6a44f23c6a866c1d7b4637ed/odoo/tools/safe_eval.py#L366-L372

[royle-vietnam]

@pedrobaeza I fixed to restrict it to version 14.0, please review, thank you

[MiquelRForgeFlow]

LGTM

[royle-vietnam]

@pedrobaeza please review this PR, thank you

[all-dm]

We're migrating a db from v12 to v14 and found this problem too. It's something new in v14 that I didn't see before. Because of this we're getting around 408 user-defined filters archived, so would be great when this pull request can be reviewed and merged.

[pedrobaeza]

Checked that no other replacement is found, so good to go

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖