Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] update_module_names: set noupdate = FALSE in remaining occurrences #273

Conversation

MiquelRForgeFlow
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow commented Jan 18, 2022

There are models, like ir.rule, where its records usually are noupdate = True, and they may affect the databases if they are left in the database.

For example, this issue happens in stock (v11) because there are two ir.rule, one in 'procurement' module and the other in 'stock' module, that both have the same xmlid name (product_pulled_flow_comp_rule), and in v11, procurement is merged in stock.

There are models, like ir.rule, where its records usually are noupdate = True, and they may affect the databases if they are left in the database.
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed internally and it totally makes sense

@pedrobaeza pedrobaeza merged commit a872be3 into OCA:master Jan 18, 2022
@MiquelRForgeFlow MiquelRForgeFlow deleted the master-imp-update_module_names-set-noupdate-renamed-xmlids branch January 18, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants