[FIX+IMP] _change_generic: Allow to transfer generic stuff between models + fix followers through SQL #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
force-pushed
the
_change_generic-new_model_name
branch
2 times, most recently
from
f451859 to
394286a
Compare
…dels + fix followers through SQL Adding a new keyword argument allows us to pass a possible new model for using this function in other contexts like transferring the generic stuff from one model to another (e.g. from account.invoice to account.move in the v12 > v13 migration). When adding this feature, I have discovered as well a bug in current code using the SQL method, where barely no followers where transferred, as the query was not having into account the model, so as soon as the partner is follower of any record of any model with such ID, then it's not transferred.
pedrobaeza
force-pushed
the
_change_generic-new_model_name
branch
from
394286a to
66a3517
Compare
pedrobaeza
commented
Jan 12, 2022
MiquelRForgeFlow
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new keyword argument allows us to pass a possible new model for using this function in other contexts like transferring the generic stuff from one model to another (e.g. from
account.invoicetoaccount.movein the v12 > v13 migration).When adding this feature, I have discovered as well a bug in current code using the SQL method, where barely no followers where transferred, as the query was not having into account the model, so as soon as the partner is follower of any record of any model with such ID, then it's not transferred.
@Tecnativa