Skip to content

[18.0][MIG] l10n_es_aeat #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 222 commits into
base: 18.0
Choose a base branch
from

Conversation

AaronHForgeFlow
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow commented Feb 21, 2025

I have tested it with #4046 and so far so good. Nevertheless, I am not sure if it is worth it to integrate with the certificate module. We would lose the feature of specifying the folder were the certificate are stored in the filesystem. And also, the password to unlock the certificates is stored in the certificate.key model, whereas in the AEAT module is not stored, but the information is extracted when the user puts the password. Of course the password cannot be filled in in the migration.

I will appreciate your help and try to attend comments in there.

@AaronHForgeFlow AaronHForgeFlow force-pushed the 18.0-mig-l10n_es_aeat branch 4 times, most recently from f35be3a to ee6fcfb Compare February 21, 2025 12:16
@AaronHForgeFlow AaronHForgeFlow force-pushed the 18.0-mig-l10n_es_aeat branch 2 times, most recently from eb76582 to dcd4311 Compare February 25, 2025 15:53
@AaronHForgeFlow AaronHForgeFlow marked this pull request as ready for review February 27, 2025 08:34
@AaronHForgeFlow
Copy link
Contributor Author

I marked this as ready mostly to see your opinion about the certificate integration:

  • We lose the feature of specifying a folder were the certificate is stored (perhaps another module can be done, like certificate_folder) to add that this feature.
  • The password do unlock the certificate is stored in the certificate.key model:
    image
  • The migration is not the typical one, I stored the information as a ir.config.parameter in order to restore it in the post-migration, but I am not convinced if this is a safe procedure or if there is a better way.

@pedrobaeza
Copy link
Member

En este repositorio se puede hablar en español sin problema, Aarón.

Sobre el primer punto, creo que no es problema no definir la carpeta. De hecho, al final pones cualquier valor.

Sobre el segundo, sí me preocupa más que digas que almacenas contraseñas privadas de certificado en la BD. ¿Eso no se puede evitar?

Los scripts de migración podemos afinarlos después de ver primero esta parte.

@AaronHForgeFlow
Copy link
Contributor Author

Gracias @pedrobaeza. Creo lo más sencillo que se me ocurre es hacer un módulo certificate_encrypt que convierta los campos de password a metodos compute y guarde las password encriptada como fields.Binary() ¿Crees que puede funcionar?

Omar (pexego) and others added 7 commits April 17, 2025 15:47
…c module for aeat models, 347 module was portedto v6.0 and adds new module to print AEAT model 349.
…ueñas mejoras generales (vistas, traducciones, código) y corrección pequeño bug por un olvido en la adaptación de la v5 a la v6
…s formatted correctly. With this number 'dec_part' would become 100 (instead of 0) and fail in the final assertion. Instead of providing a workaround for this case, I simply replace the formatting with '%0*.*f' which seems easier specially because it already does the appropriate rounding.
…recía Pexego en la licencia, quedan los compartidos.
…ron marcados como no instalables mientras no se compruebe que funcionan o migren, para poder usarlos o probarlos se debería poner el atributo installable de los ficheros __openerp__.py de cada módulo a True
weblate and others added 28 commits April 17, 2025 15:47
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-17.0/l10n-spain-17.0-l10n_es_aeat
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-17-0/l10n-spain-17-0-l10n_es_aeat/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-17.0/l10n-spain-17.0-l10n_es_aeat
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-17-0/l10n-spain-17-0-l10n_es_aeat/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-17.0/l10n-spain-17.0-l10n_es_aeat
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-17-0/l10n-spain-17-0-l10n_es_aeat/
Creación de un nuevo modelo en `l10n_es_aeat` llamado *aeat_mixin*, del
que heredan *sii.mixin* (ya existente) y un nuevo *verifactu.mixin*.
Refactor de *sii.mixin* pasando funcionalidad a *aeat_mixin*
Se han renombrado varios campos sii_* a aeat_* ya que serán utilizados
por ambos.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-17.0/l10n-spain-17.0-l10n_es_aeat
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-17-0/l10n-spain-17-0-l10n_es_aeat/
Since odoo/odoo#179797, IVA 5% taxes templates are deactivated, and
if you calculate an AEAT report containing them, they are not included
as not being included in the m2m field.

This commit takes this situation into account.

TT51059
It's more significant to have first the latest AEAT reports than the
first ones.
Allow to drill through in the tax summary to list journal items that
leads to the base and tax amounts.

As we are on this, there's a tool method now in base module l10n_es_aeat
for opening this kind of view, and fixing that the journal items was
always open with move grouping by default.

TT52996
…ments

The following dependencies: cryptography, zeep, and requests are used in
different modules, but we remove them from being required because they are
already included in Odoo's requirements.txt.
Having them in both places creates maintenance overhead and potential conflicts.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-17.0/l10n-spain-17.0-l10n_es_aeat
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-17-0/l10n-spain-17-0-l10n_es_aeat/
Models like 303 and 390 have a lot of fields, so showing them all even
if the amount is 0 can be counterproductive. Thanks to the magic of
one2many fields, we can continue calculating all the fields and showing
them for traceability purposes, but filter out in another o2m field
those with amount with hardly no cost, and now 2 tabs are shown for
these lines, having precedence the filtered one.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-17.0/l10n-spain-17.0-l10n_es_aeat
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-17-0/l10n-spain-17-0-l10n_es_aeat/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.