15.0[IMP] document_page: menu_parent_id context domain of menu creation #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaraldPanten
changed the title
HaraldPanten
requested changes
Jan 21, 2025
|
@HaraldPanten is the same name of the commit in v.16 . it's a port. |
|
It's a port, but it has an incorrect name. Enric, we should correct the commit message, right? |
It would have to be fixed in v16 first and then the fix brought to v15 |
|
I would leave the message as it is. As a good practice, it is better to avoid version name on the commits. The only exception is migration commits |
HaraldPanten
approved these changes
Jan 21, 2025
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at a42bf70. Thanks a lot for contributing to OCA. ❤️ |
HaraldPanten
deleted the
15.0-imp-document_page_menu_create-menu_parent_id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port -> #448